-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests and merge in some other PR's #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this PR needs an update for derecho if you still want to merge it.
cism runoff will be now routed to ocn via mosart Enables CISM runoff to be routed to the ocean via mosart. All runoff from CISM will be routed directly to the outlet points New fields will be advertised in the mosart cap call fldlist_add(fldsFrRof_num, fldsFrRof, 'Forr_rofl_glc') call fldlist_add(fldsFrRof_num, fldsFrRof, 'Forr_rofi_glc') Conflicts: cime_config/testdefs/testlist_mosart.xml
Adds more tests on izumi as well as some gnu and one nvhpc test.
it isn't functional yet. Would be good for testing though. This resolves ESCOMP#61
This fixes ESCOMP#91
@slevis-lmwg I did some work on this. And I'm viewing it as at a place for you to complete the tag for. Let me know if there's anything we need to go over. Adding more testing before we go ahead and make several tags seems like the best ordering of things. I also went through the MOSART issues and flagged a couple as things we perhaps should work on. As well as marking a bunch as lower priority that we don't need to worry about right now. |
Submitting the mosart test-suites next. |
Sorry, I have to partly back out 891a45d because now i'm getting |
Thinking about this I think we probably should use mostly the same compsets for these MOSART tests. Answers will be different for Sp vs. BgcCru cases -- but in terms of MOSART do we need to test with both SP and BGC? And with different forcing? We should exercise all the MOSART options -- but maybe use the same general compset for all. The differences that do matter are 1850 vs 2000 vs HIST as well as when CISM is used. Part of the philosophy of spanning many compsets is to show that MOSART continues to work under standard things that change answers. But, I don't think we've seen tests show problems under different compsets that primarily change CLM answers. So I think we should maybe drop this and simplify the testing compsets. @slevis-lmwg should we maybe have a quick meeting about this? |
On izumi this fails, including with vanilla mosart
@ekluzek @jedwards4b let me know if we can live without testing on izumi or if we need this fixed before I proceed. |
@slevis-lmwg we should figure out what is up with testing on Izumi, and get it resolved and working. This problem isn't something specific for MOSART it must be something about the CTSM version being used here... @jedwards4b don't worry about this -- we'll figure it out... |
@mvdebolskiy @mvertens |
@jedwards4b can you approve this now? It looks like it's held up until you approve it. We could dismiss your review -- because it was addressed. But, better for you to just click approve. Thanks. |
Generating baselines: Comparing to baselines: |
@slevis-lmwg @mvertens |
|
New tag |
PR ESCOMP#70 add more tests especially on izumi and merge other PRs Resolves ESCOMP#68 Resolves ESCOMP#79 Resolves ESCOMP#61 Resolves ESCOMP#91 Resolves ESCOMP#103 Resolves ESCOMP#104 Resolves ESCOMP#107
Add in more tests, and merge in some of the other PR's
Adds more tests, especially on izumi.
Resolves #68
Resolves #79
Resolves #61
Resolves #91
Resolves #103
Resolves #104
Resolves #107